linux-kernel - Re: [PATCH 6/6] media: i2c: Convert to new i2c device probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 31 Jul 2019 21:53:46 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
Cc:     linux-i2c@...r.kernel.org, linux-media@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Leon Luo <leonl@...pardimaging.com>,
        Ramesh Shanmugasundaram <ramesh.shanmugasundaram@...renesas.com>,
        "Lad, Prabhakar" <prabhakar.csengg@...il.com>,
        Steve Longerbeam <slongerbeam@...il.com>,
        Luis Oliveira <lolivei@...opsys.com>,
        Jacopo Mondi <jacopo@...ndi.org>,
        Wenyou Yang <wenyou.yang@...rochip.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Akinobu Mita <akinobu.mita@...il.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Mats Randgaard <matrandg@...co.com>,
        Hans Verkuil <hans.verkuil@...co.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Marco Felsch <m.felsch@...gutronix.de>,
        Michael Grzeschik <m.grzeschik@...gutronix.de>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Enrico Scholz <enrico.scholz@...ma-chemnitz.de>,
        Simon Horman <horms+renesas@...ge.net.au>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Allison Randal <allison@...utok.net>,
        Richard Fontana <rfontana@...hat.com>,
        Todor Tomov <todor.tomov@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Julia Lawall <Julia.Lawall@...6.fr>,
        Alexey Khoroshilov <khoroshilov@...ras.ru>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/6] media: i2c: Convert to new i2c device probe()

On Wed, Jul 10, 2019 at 10:51:49PM +0100, Kieran Bingham wrote:
> The I2C core framework provides a simplified probe framework from commit
> b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type").
> 
> These drivers do not utilise the i2c_device_id table in the probe, so we
> can easily convert them to utilise the simplfied i2c driver
> registration.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
> ---
>  drivers/media/i2c/adv7343.c  | 5 ++---
>  drivers/media/i2c/imx274.c   | 5 ++---
>  drivers/media/i2c/max2175.c  | 5 ++---
>  drivers/media/i2c/mt9m001.c  | 5 ++---
>  drivers/media/i2c/mt9m111.c  | 5 ++---
>  drivers/media/i2c/ov2640.c   | 5 ++---
>  drivers/media/i2c/ov2659.c   | 5 ++---
>  drivers/media/i2c/ov5640.c   | 5 ++---
>  drivers/media/i2c/ov5645.c   | 5 ++---
>  drivers/media/i2c/ov5647.c   | 5 ++---
>  drivers/media/i2c/ov772x.c   | 5 ++---
>  drivers/media/i2c/ov7740.c   | 5 ++---
>  drivers/media/i2c/ov9650.c   | 5 ++---
>  drivers/media/i2c/s5k5baf.c  | 5 ++---
>  drivers/media/i2c/s5k6a3.c   | 5 ++---
>  drivers/media/i2c/tc358743.c | 5 ++---
>  drivers/media/i2c/ths8200.c  | 5 ++---
>  drivers/media/i2c/tvp5150.c  | 5 ++---
>  drivers/media/i2c/tvp7002.c  | 4 ++--

These drivers, I did not review visually but build tested them and
verified they didn't show any build warnings or failures. Glimpsed
through the conversion pattern. Looks all good.

Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)