lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <201907311259.D485EED2B7@keescook>
Date:   Wed, 31 Jul 2019 12:59:30 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Joonwon Kang <kjw1627@...il.com>
Cc:     re.emese@...il.com, kernel-hardening@...ts.openwall.com,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        jinb.park7@...il.com
Subject: Re: [PATCH 2/2] randstruct: remove dead code in is_pure_ops_struct()

On Thu, Aug 01, 2019 at 03:01:49AM +0900, Joonwon Kang wrote:
> Recursive declaration for struct which has member of the same struct
> type, for example,
> 
> struct foo {
>     struct foo f;
>     ...
> };
> 
> is not allowed. So, it is unnecessary to check if a struct has this
> kind of member.

Is that the only case where this loop could happen? Seems also safe to
just leave it as-is...

-Kees

> 
> Signed-off-by: Joonwon Kang <kjw1627@...il.com>
> ---
>  scripts/gcc-plugins/randomize_layout_plugin.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/scripts/gcc-plugins/randomize_layout_plugin.c b/scripts/gcc-plugins/randomize_layout_plugin.c
> index bd29e4e7a524..e14efe23e645 100644
> --- a/scripts/gcc-plugins/randomize_layout_plugin.c
> +++ b/scripts/gcc-plugins/randomize_layout_plugin.c
> @@ -440,9 +440,6 @@ static int is_pure_ops_struct(const_tree node)
>  		const_tree fieldtype = get_field_type(field);
>  		enum tree_code code = TREE_CODE(fieldtype);
>  
> -		if (node == fieldtype)
> -			continue;
> -
>  		if (code == RECORD_TYPE || code == UNION_TYPE) {
>  			if (!is_pure_ops_struct(fieldtype))
>  				return 0;
> -- 
> 2.17.1
> 

-- 
Kees Cook

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ