[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1c979e3f-54ec-cce8-650c-39e060e72169@huawei.com>
Date: Wed, 31 Jul 2019 15:05:36 +0800
From: Chao Yu <yuchao0@...wei.com>
To: Gao Xiang <gaoxiang25@...wei.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
<devel@...verdev.osuosl.org>
CC: <linux-erofs@...ts.ozlabs.org>,
LKML <linux-kernel@...r.kernel.org>, <weidu.du@...wei.com>,
Miao Xie <miaoxie@...wei.com>
Subject: Re: [PATCH 08/22] staging: erofs: kill CONFIG_EROFS_FS_IO_MAX_RETRIES
On 2019/7/29 14:51, Gao Xiang wrote:
> CONFIG_EROFS_FS_IO_MAX_RETRIES seems a runtime setting
> and users have no idea about the change in behaviour.
>
> Let's remove the setting currently and fold it into code,
> turn it into a module parameter if it's really needed.
>
> Suggested-by: David Sterba <dsterba@...e.cz>
> Signed-off-by: Gao Xiang <gaoxiang25@...wei.com>
It's fine to me, but I'd like to suggest to add this as a sys entry which can be
more flexible for user to change.
Thanks
Powered by blists - more mailing lists