Message-ID: <6560f93c-a48f-2a8c-afeb-d5e8e200480d@baylibre.com>
Date:   Wed, 31 Jul 2019 10:00:14 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Sam Ravnborg <sam@...nborg.org>,
        Andrzej Pietrasiewicz <andrzej.p@...labora.com>
Cc:     David Airlie <airlied@...ux.ie>, Liviu Dudau <liviu.dudau@....com>,
        dri-devel@...ts.freedesktop.org,
        Douglas Anderson <dianders@...omium.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        kernel@...labora.com, linux-samsung-soc@...r.kernel.org,
        Jyri Sarha <jsarha@...com>,
        Vincent Abriou <vincent.abriou@...com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-rockchip@...ts.infradead.org, Chen-Yu Tsai <wens@...e.org>,
        Kukjin Kim <kgene@...nel.org>,
        NXP Linux Team <linux-imx@....com>,
        Dave Airlie <airlied@...hat.com>,
        intel-gfx@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
        linux-tegra@...r.kernel.org, Jonas Karlman <jonas@...boo.se>,
        linux-arm-msm@...r.kernel.org, Maxime Ripard <mripard@...nel.org>,
        Mamta Shukla <mamtashukla555@...il.com>,
        linux-mediatek@...ts.infradead.org,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Sean Paul <sean@...rly.run>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        linux-arm-kernel@...ts.infradead.org,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        amd-gfx@...ts.freedesktop.org,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Seung-Woo Kim <sw0312.kim@...sung.com>,
        linux-kernel@...r.kernel.org, Todor Tomov <todor.tomov@...aro.org>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Huang Rui <ray.huang@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alex Deucher <alexander.deucher@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Christian König <christian.koenig@....com>,
        Gerd Hoffmann <kraxel@...hat.com>
Subject: Re: Review required [Was: Associate ddc adapters with connectors]

Hi Sam,

On 26/07/2019 20:55, Sam Ravnborg wrote:
> Hi all.
> 
> Andrzej have done a good job following up on feedback and this series is
> now ready.
> 
> We need ack on the patches touching the individual drivers before we can
> proceed.
> Please check your drivers and get back.

I can apply all core and maintainer-acked patches for now :
1, 2, 7, 10, 11, 16, 17, 18, 19, 20, 21, 22, 23

and Andrzej can resend not applied patches with Yours and Emil's Reviewed-by,
so we can wait a few more days to apply them.

Neil

> 
> 	Sam
> 
>> Hi Andezej.
>>
>> On Fri, Jul 26, 2019 at 07:22:54PM +0200, Andrzej Pietrasiewicz wrote:
>>> It is difficult for a user to know which of the i2c adapters is for which
>>> drm connector. This series addresses this problem.
>>>
>>> The idea is to have a symbolic link in connector's sysfs directory, e.g.:
>>>
>>> ls -l /sys/class/drm/card0-HDMI-A-1/ddc
>>> lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \
>>> 	-> ../../../../soc/13880000.i2c/i2c-2
>>>
>>> The user then knows that their card0-HDMI-A-1 uses i2c-2 and can e.g. run
>>> ddcutil:
>>>
>>> ddcutil -b 2 getvcp 0x10
>>> VCP code 0x10 (Brightness): current value =    90, max value =   100
>>>
>>> The first patch in the series adds struct i2c_adapter pointer to struct
>>> drm_connector. If the field is used by a particular driver, then an
>>> appropriate symbolic link is created by the generic code, which is also added
>>> by this patch.
>>>
>>> Patch 2 adds a new variant of drm_connector_init(), see the changelog
>>> below.
>>>
>>> Patches 3..24 are examples of how to convert a driver to this new scheme.
>>>
>> ...
>>>
>>> v5..v6:
>>>
>>> - improved subject line of patch 1
>>> - added kernel-doc for drm_connector_init_with_ddc()
>>> - improved kernel-doc for the ddc field of struct drm_connector
>>> - added Reviewed-by in patches 17 and 18
>>> - added Acked-by in patch 2
>>> - made the ownership of ddc i2c_adapter explicit in all patches,
>>> this made the affected patches much simpler
>>
>> Looks good now.
>> Patch 1 and 2 are:
>> Reviewed-by: Sam Ravnborg <sam@...nborg.org>
>>
>> The remaining patches are:
>> Acked-by: Sam Ravnborg <sam@...nborg.org>
>>
>> 	Sam
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@...ts.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Powered by blists - more mailing lists