linux-kernel - Re: [PATCH] linux/coff.h: add include guard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNATSaZVdFm4=mODoAUnjwf3QKS5Fx5drkZ-yGDHTabfPsQ@mail.gmail.com>
Date:   Wed, 31 Jul 2019 18:23:01 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] linux/coff.h: add include guard

Hi Andrew,

On Wed, Jul 31, 2019 at 4:52 AM Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> On Mon, 29 Jul 2019 00:47:28 +0900 Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:
>
> > Add a header include guard just in case.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> > ---
> >
> > Looks like this file is unused at least in the kernel tree,
> > but I am not it is OK to delete it.
>
> arch/alpha/boot/tools/objstrip.c includes it but I don't think it's
> actually needed.  Yes, it would be nice to kill coff.h.

After some consideration, I think it is better to keep it
until we dump the alpha support entirely.

The following line in arch/alpha/boot/tools/objstrip.c
references a macro in <linux/coff.h>:

        if (!(aout->fh.f_flags & COFF_F_EXEC)) {

I was not able to build objstrip.c anyway,
but I think it is better to keep the can of worms closed for now.

Could you apply this as-is please?

My motivation is to allow Kbuild to detect missing include guard:

https://patchwork.kernel.org/patch/11063011/

Before I enable this checker,
I want to fix as many headers as possible.

-- 
Best Regards
Masahiro Yamada