linux-kernel - Re: [PATCH for-4.14.y 3/3] crypto: crypto4xx - fix a potential double free in ppc4xx_trng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190731094437.GF18269@kroah.com>
Date:   Wed, 31 Jul 2019 11:44:37 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Amit Pundir <amit.pundir@...aro.org>
Cc:     Stable <stable@...r.kernel.org>, Wen Yang <wen.yang99@....com.cn>,
        "David S. Miller" <davem@...emloft.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Allison Randal <allison@...utok.net>,
        Armijn Hemel <armijn@...ldur.nl>,
        Julia Lawall <Julia.Lawall@...6.fr>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH for-4.14.y 3/3] crypto: crypto4xx - fix a potential
 double free in ppc4xx_trng_probe

On Wed, Jul 31, 2019 at 01:48:33AM +0530, Amit Pundir wrote:
> From: Wen Yang <wen.yang99@....com.cn>
> 
> commit 95566aa75cd6b3b404502c06f66956b5481194b3 upstream.
> 
> There is a possible double free issue in ppc4xx_trng_probe():
> 
> 85:	dev->trng_base = of_iomap(trng, 0);
> 86:	of_node_put(trng);          ---> released here
> 87:	if (!dev->trng_base)
> 88:		goto err_out;
> ...
> 110:	ierr_out:
> 111:		of_node_put(trng);  ---> double released here
> ...
> 
> This issue was detected by using the Coccinelle software.
> We fix it by removing the unnecessary of_node_put().
> 
> Fixes: 5343e674f32f ("crypto4xx: integrate ppc4xx-rng into crypto4xx")
> Signed-off-by: Wen Yang <wen.yang99@....com.cn>
> Cc: <stable@...r.kernel.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Allison Randal <allison@...utok.net>
> Cc: Armijn Hemel <armijn@...ldur.nl>
> Cc: Julia Lawall <Julia.Lawall@...6.fr>
> Cc: linux-crypto@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Acked-by: Julia Lawall <julia.lawall@...6.fr>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> Signed-off-by: Amit Pundir <amit.pundir@...aro.org>
> ---
> Cleanly apply on 4.9.y as well.

This is already in the 4.14.135 kernel release.  Are you sure we need it
there again?

thanks,

greg k-h