linux-kernel - Re: [PATCH] fs: reiserfs: Remove unnecessary check of bh in remove_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190731094819.GB15806@quack2.suse.cz>
Date:   Wed, 31 Jul 2019 11:48:19 +0200
From:   Jan Kara <jack@...e.cz>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     jack@...e.cz, akpm@...ux-foundation.org, arnd@...db.de,
        hariprasad.kelam@...il.com, linux.bhar@...il.com,
        reiserfs-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: reiserfs: Remove unnecessary check of bh in
 remove_from_transaction()

On Sat 27-07-19 16:40:19, Jia-Ju Bai wrote:
> On lines 3430-3434, bh has been assured to be non-null:
>     cn = get_journal_hash_dev(sb, journal->j_hash_table, blocknr);
>     if (!cn || !cn->bh) {
>         return ret;
>     }
>     bh = cn->bh;
> 
> Thus, the check of bh on line 3447 is unnecessary and can be removed.
> Thank Andrew Morton for good advice.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>

Looks good to me. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/reiserfs/journal.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> index 4517a1394c6f..11155b8513db 100644
> --- a/fs/reiserfs/journal.c
> +++ b/fs/reiserfs/journal.c
> @@ -3444,9 +3444,8 @@ static int remove_from_transaction(struct super_block *sb,
>  	if (cn == journal->j_last) {
>  		journal->j_last = cn->prev;
>  	}
> -	if (bh)
> -		remove_journal_hash(sb, journal->j_hash_table, NULL,
> -				    bh->b_blocknr, 0);
> +	remove_journal_hash(sb, journal->j_hash_table, NULL,
> +			    bh->b_blocknr, 0);
>  	clear_buffer_journaled(bh);	/* don't log this one */
>  
>  	if (!already_cleaned) {
> -- 
> 2.17.0
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR