linux-kernel - Re: [PATCH] gpio: ixp4xx: remove redundant dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 31 Jul 2019 12:05:04 +0200
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Ding Xiang <dingxiang@...s.chinamobile.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: ixp4xx: remove redundant dev_err message

śr., 31 lip 2019 o 11:48 Ding Xiang <dingxiang@...s.chinamobile.com> napisał(a):
>
> devm_ioremap_resource already contains error message, so remove
> the redundant dev_err message
>
> Signed-off-by: Ding Xiang <dingxiang@...s.chinamobile.com>
> ---
>  drivers/gpio/gpio-ixp4xx.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ixp4xx.c b/drivers/gpio/gpio-ixp4xx.c
> index 670c2a8..2b2b89b 100644
> --- a/drivers/gpio/gpio-ixp4xx.c
> +++ b/drivers/gpio/gpio-ixp4xx.c
> @@ -321,10 +321,8 @@ static int ixp4xx_gpio_probe(struct platform_device *pdev)
>
>         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>         g->base = devm_ioremap_resource(dev, res);
> -       if (IS_ERR(g->base)) {
> -               dev_err(dev, "ioremap error\n");
> +       if (IS_ERR(g->base))
>                 return PTR_ERR(g->base);
> -       }
>
>         /*
>          * Make sure GPIO 14 and 15 are NOT used as clocks but GPIO on
> --
> 1.9.1
>
>
>

Patch applied, thanks!

Bart