linux-kernel - Re: [PATCH] HID: logitech-dj: Fix check of logi_dj_recv_query_paired

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e9bda5b-68dc-15b9-ca79-2e73567ea0a5@redhat.com>
Date:   Wed, 31 Jul 2019 13:29:33 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Petr Vorel <pvorel@...e.cz>, YueHaibing <yuehaibing@...wei.com>
Cc:     jikos@...nel.org, benjamin.tissoires@...hat.com,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH] HID: logitech-dj: Fix check of
 logi_dj_recv_query_paired_devices()

Hi Petr,

On 31-07-19 13:06, Petr Vorel wrote:
> Hi,
> 
>>> In delayedwork_callback(), logi_dj_recv_query_paired_devices
>>> may return positive value while success now, so check it
>>> correctly.
> 
>>> Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices")
>>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> Reviewed-by: Petr Vorel <pvorel@...e.cz>
> OK, not only it didn't fix problems with logitech mouse (see below),
> but removing mouses USB dongle effectively crashes kernel, so this one probably
> shouldn't be applied :).
> 
> [  330.721629] logitech-djreceiver: probe of 0003:046D:C52F.0013 failed with error 7
> [  331.462335] hid 0003:046D:C52F.0013: delayedwork_callback: logi_dj_recv_query_paired_devices error: 7

Please test my patch titled: "HID: logitech-dj: Really fix return value of logi_dj_recv_query_hidpp_devices"
which should fix this.

Regards,

Hans