linux-kernel - Re: [PATCH] fgraph: Remove redundant ftrace_graph_notrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190731075837.6d2a3995@gandalf.local.home>
Date:   Wed, 31 Jul 2019 07:58:37 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Changbin Du <changbin.du@...il.com>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fgraph: Remove redundant ftrace_graph_notrace_addr()
 test

On Wed, 31 Jul 2019 18:31:45 +0800
Changbin Du <changbin.du@...il.com> wrote:

> On Tue, Jul 30, 2019 at 12:15:27PM -0400, Steven Rostedt wrote:
> > On Tue, 30 Jul 2019 22:08:50 +0800
> > Changbin Du <changbin.du@...il.com> wrote:
> >   
> > > We already have tested it before. The second one should be removed.
> > > With this change, the performance should have little improvement.
> > > 
> > > Fixes: 9cd2992f2d6c ("fgraph: Have set_graph_notrace only affect function_graph tracer")  
> > 
> > Thanks! I think this should even be marked for stable. Not really a bad
> > bug, but a bug none the less.
> >  
> Steven, need I resend this patch and cc stable mailist?
> 

No.

I actually already pulled it in and ran it through my tests. I'm
waiting on some more tests before pushing it off to Linus.

-- Steve