linux-kernel - Re: [PATCH] crypto: atmel-sha204a: Use device-managed registration API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 Jul 2019 14:04:20 +0200
From:   Ludovic Desroches <ludovic.desroches@...rochip.com>
To:     Chuhong Yuan <hslester96@...il.com>
CC:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        "Alexandre Belloni" <alexandre.belloni@...tlin.com>,
        <linux-crypto@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: atmel-sha204a: Use device-managed registration
 API

On Tue, Jul 23, 2019 at 03:19:36PM +0800, Chuhong Yuan wrote:
> 
> Use devm_hwrng_register to get rid of manual
> unregistration.
> 
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>
Acked-by: Ludovic Desroches <ludovic.desroches@...rochip.com>

Thanks

> ---
>  drivers/crypto/atmel-sha204a.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
> index ea0d2068ea4f..c96c14e7dab1 100644
> --- a/drivers/crypto/atmel-sha204a.c
> +++ b/drivers/crypto/atmel-sha204a.c
> @@ -109,7 +109,7 @@ static int atmel_sha204a_probe(struct i2c_client *client,
>  	i2c_priv->hwrng.read = atmel_sha204a_rng_read;
>  	i2c_priv->hwrng.quality = 1024;
>  
> -	ret = hwrng_register(&i2c_priv->hwrng);
> +	ret = devm_hwrng_register(&client->dev, &i2c_priv->hwrng);
>  	if (ret)
>  		dev_warn(&client->dev, "failed to register RNG (%d)\n", ret);
>  
> @@ -127,7 +127,6 @@ static int atmel_sha204a_remove(struct i2c_client *client)
>  
>  	if (i2c_priv->hwrng.priv)
>  		kfree((void *)i2c_priv->hwrng.priv);
> -	hwrng_unregister(&i2c_priv->hwrng);
>  
>  	return 0;
>  }
> -- 
> 2.20.1
> 
>