linux-kernel - Re: [RT PATCH] sched/deadline: Make inactive timer run in hardirq context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190731092507.3c57d4db@torg.hsv.redhat.com>
Date:   Wed, 31 Jul 2019 09:25:07 -0500
From:   Clark Williams <williams@...hat.com>
To:     Juri Lelli <juri.lelli@...hat.com>
Cc:     tglx@...utronix.de, bigeasy@...utronix.de, rostedt@...dmis.org,
        linux-rt-users@...r.kernel.org, peterz@...radead.org,
        linux-kernel@...r.kernel.org, bristot@...hat.com
Subject: Re: [RT PATCH] sched/deadline: Make inactive timer run in hardirq
 context

On Wed, 31 Jul 2019 12:37:15 +0200
Juri Lelli <juri.lelli@...hat.com> wrote:

> SCHED_DEADLINE inactive timer needs to run in hardirq context (as
> dl_task_timer already does).
> 
> Make it HRTIMER_MODE_REL_HARD.
> 
> Signed-off-by: Juri Lelli <juri.lelli@...hat.com>
> ---
> Hi,
> 
> Both v4.19-rt and v5.2-rt need this.
> 
> Mainline "sched: Mark hrtimers to expire in hard interrupt context"
> series needs this as well (20190726185753.077004842@...utronix.de in
> particular). Do I need to send out a separate patch for it?
> 
> Best,
> 
> Juri
> ---
>  kernel/sched/deadline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 1794e152d888..0889674b8915 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1292,7 +1292,7 @@ void init_dl_inactive_task_timer(struct sched_dl_entity *dl_se)
>  {
>  	struct hrtimer *timer = &dl_se->inactive_timer;
>  
> -	hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> +	hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_HARD);
>  	timer->function = inactive_task_timer;
>  }
>  
> -- 
> 2.17.2
> 
Acked-by: Clark Williams <williams@...hat.com>

-- 
The United States Coast Guard
Ruining Natural Selection since 1790