linux-kernel - Re: [PATCH v6 18/57] i2c: Remove dev_err() usage after platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d41a9d8.1c69fb81.bdbb9.bea3@mx.google.com>
Date:   Wed, 31 Jul 2019 07:46:47 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v6 18/57] i2c: Remove dev_err() usage after platform_get_irq()

Quoting Wolfram Sang (2019-07-31 07:30:11)
> > -dev_err(...);
> 
> What about pr_err, ...?

Sure. I haven't tried to find these ones or pr_warn(), etc.

> 
> > While we're here, remove braces on if statements that only have one
> > statement (manually).
> 
> You can let cocci do this for you, too. From the top of my head:
> 
> if (...)
> - {
>  S
> - }
> 
> with S being a statement and this rule depending on the matching rule.
> 

Cool thanks for the tip! I'll have to try it out.