linux-kernel - Re: [PATCH net-next 0/5] net: dsa: mv88e6xxx: avoid some redundant VTU operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190801.164345.1007767435484564146.davem@davemloft.net>
Date:   Thu, 01 Aug 2019 16:43:45 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     vivien.didelot@...il.com
Cc:     linux-kernel@...r.kernel.org, rasmus.villemoes@...vas.dk,
        f.fainelli@...il.com, andrew@...n.ch, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/5] net: dsa: mv88e6xxx: avoid some redundant
 VTU operations

From: Vivien Didelot <vivien.didelot@...il.com>
Date: Thu,  1 Aug 2019 14:36:32 -0400

> The mv88e6xxx driver currently uses a mv88e6xxx_vtu_get wrapper to get a
> single entry and uses a boolean to eventually initialize a fresh one.
> 
> However the fresh entry is only needed in one place and mv88e6xxx_vtu_getnext
> is simple enough to call it directly. Doing so makes the code easier to read,
> especially for the return code expected by switchdev to honor software VLANs.
> 
> In addition to not loading the VTU again when an entry is already correctly
> programmed, this also allows to avoid programming the broadcast entries
> again when updating a port's membership, from e.g. tagged to untagged.
> 
> This patch series removes the mv88e6xxx_vtu_get wrapper in favor of direct
> calls to mv88e6xxx_vtu_getnext, and also renames the _mv88e6xxx_port_vlan_add
> and _mv88e6xxx_port_vlan_del helpers using an old underscore prefix convention.
> 
> In case the port's membership is already correctly programmed in hardware,
> the following debug message may be printed:
> 
>     [  745.989884] mv88e6085 2188000.ethernet-1:00: p4: already a member of VLAN 42

Series applied, thanks Vivien.