[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAFd5g47tk8x5iet=xfPVO6MphD3SsLtYQLrCi5O2h0bvdXwHtA@mail.gmail.com>
Date: Thu, 1 Aug 2019 14:43:42 -0700
From: Brendan Higgins <brendanhiggins@...gle.com>
To: Stephen Boyd <sboyd@...nel.org>
Cc: Petr Mladek <pmladek@...e.com>, Jeff Dike <jdike@...toit.com>,
Kevin Hilman <khilman@...libre.com>,
Logan Gunthorpe <logang@...tatee.com>,
Michael Ellerman <mpe@...erman.id.au>,
Daniel Vetter <daniel@...ll.ch>,
Amir Goldstein <amir73il@...il.com>,
Frank Rowand <frowand.list@...il.com>,
Steven Rostedt <rostedt@...dmis.org>,
Kees Cook <keescook@...gle.com>,
David Rientjes <rientjes@...gle.com>,
kunit-dev@...glegroups.com,
Kieran Bingham <kieran.bingham@...asonboard.com>,
Peter Zijlstra <peterz@...radead.org>,
Randy Dunlap <rdunlap@...radead.org>,
Joel Stanley <joel@....id.au>,
Luis Chamberlain <mcgrof@...nel.org>,
Rob Herring <robh@...nel.org>, shuah <shuah@...nel.org>,
wfg@...ux.intel.com, Greg KH <gregkh@...uxfoundation.org>,
Julia Lawall <julia.lawall@...6.fr>,
linux-nvdimm <linux-nvdimm@...ts.01.org>,
dri-devel <dri-devel@...ts.freedesktop.org>,
linux-um@...ts.infradead.org,
Sasha Levin <Alexander.Levin@...rosoft.com>,
"Theodore Ts'o" <tytso@....edu>,
Richard Weinberger <richard@....at>,
Dan Carpenter <dan.carpenter@...cle.com>,
Knut Omang <knut.omang@...cle.com>,
Josh Poimboeuf <jpoimboe@...hat.com>,
Masahiro Yamada <yamada.masahiro@...ionext.com>,
Timothy Bird <Tim.Bird@...y.com>,
John Ogness <john.ogness@...utronix.de>,
devicetree <devicetree@...r.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
linux-fsdevel@...r.kernel.org,
linux-kbuild <linux-kbuild@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger
On Thu, Aug 1, 2019 at 2:14 PM Stephen Boyd <sboyd@...nel.org> wrote:
>
> Quoting Brendan Higgins (2019-08-01 11:59:57)
> > On Thu, Aug 1, 2019 at 11:55 AM Brendan Higgins
> > <brendanhiggins@...gle.com> wrote:
> > >
> > > On Fri, Jul 26, 2019 at 1:31 AM Petr Mladek <pmladek@...e.com> wrote:
> > >
> > > > To be honest I do not fully understand KUnit design. I am not
> > > > completely sure how the tested code is isolated from the running
> > > > system. Namely, I do not know if the tested code shares
> > > > the same locks with the system running the test.
> > >
> > > No worries, I don't expect printk to be the hang up in those cases. It
> > > sounds like KUnit has a long way to evolve before printk is going to
> > > be a limitation.
> >
> > So Stephen, what do you think?
> >
> > Do you want me to go forward with the new kunit_assert API wrapping
> > the string_stream as I have it now? Would you prefer to punt this to a
> > later patch? Or would you prefer something else?
> >
>
> I like the struct based approach. If anything, it can be adjusted to
> make the code throw some records into a spinlock later on and delay the
> formatting of the assertion if need be.
That's a fair point.
> Can you resend with that
> approach? I don't think I'll have any more comments after that.
Cool, will do.
Thanks!
Powered by blists - more mailing lists