linux-kernel - Re: [PATCH 2/3] firmware: add offset to request_firmware_into

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190801061801.GA4338@kroah.com>
Date:   Thu, 1 Aug 2019 08:18:01 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Scott Branden <scott.branden@...adcom.com>
Cc:     Luis Chamberlain <mcgrof@...nel.org>,
        David Brown <david.brown@...aro.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-fsdevel@...r.kernel.org,
        BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>,
        Olof Johansson <olof@...om.net>
Subject: Re: [PATCH 2/3] firmware: add offset to request_firmware_into_buf

On Wed, Jul 31, 2019 at 05:18:32PM -0700, Scott Branden wrote:
> Hi Greg,
> 
> I am now back from leave to continue this patch.  Comment below.
> 
> On 2019-05-23 10:22 p.m., Greg Kroah-Hartman wrote:
> > On Thu, May 23, 2019 at 10:01:38PM -0700, Scott Branden wrote:
> > > On 2019-05-23 9:54 a.m., Greg Kroah-Hartman wrote:
> > > > On Thu, May 23, 2019 at 09:36:02AM -0700, Scott Branden wrote:
> > > > > Hi Greg,
> > > > > 
> > > > > On 2019-05-22 10:52 p.m., Greg Kroah-Hartman wrote:
> > > > > > On Wed, May 22, 2019 at 07:51:12PM -0700, Scott Branden wrote:
> > > > > > > Add offset to request_firmware_into_buf to allow for portions
> > > > > > > of firmware file to be read into a buffer.  Necessary where firmware
> > > > > > > needs to be loaded in portions from file in memory constrained systems.
> > > > > > > 
> > > > > > > Signed-off-by: Scott Branden <scott.branden@...adcom.com>
> > > > > > > ---
> > > > > > >     drivers/base/firmware_loader/firmware.h |  5 +++
> > > > > > >     drivers/base/firmware_loader/main.c     | 49 +++++++++++++++++--------
> > > > > > >     include/linux/firmware.h                |  8 +++-
> > > > > > >     3 files changed, 45 insertions(+), 17 deletions(-)
> > > > > > No new firmware test for this new option?  How do we know it even works?
> > > > > I was unaware there are existing firmware tests.  Please let me know where
> > > > > these tests exists and I can add a test for this new option.
> > > > tools/testing/selftests/firmware/
> > > Unfortunately, there doesn't seem to be a test for the existing
> > > request_firmware_into_buf api.
> > Are you sure?  The test is for userspace functionality, there isn't
> > kernel unit tests here.  You need to verify that you didn't break
> > existing functionality as well as verify that your new functionality
> > works.
> 
> I managed to figure out how to build and run
> tools/testing/selftest/firmware/fw_run_tests.sh
> 
> and my changes don't break existing functionality.
> 
> But, I find no use of request_firmware_into_buf in lib/test_firmware.c
> (triggered by fw_run_tests.sh).
> 
> Is there another test for request_firmware_into_buf?

I have no idea, sorry.

greg k-h