linux-kernel - Re: [patch V2 4/7] fs/jbd2: Remove jbd_trylock_bh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190801090042.GE25064@quack2.suse.cz>
Date:   Thu, 1 Aug 2019 11:00:42 +0200
From:   Jan Kara <jack@...e.cz>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Sebastian Siewior <bigeasy@...utronix.de>,
        Anna-Maria Gleixner <anna-maria@...utronix.de>,
        Steven Rostedt <rostedt@...dmis.org>,
        Julia Cartwright <julia@...com>, linux-ext4@...r.kernel.org,
        Theodore Tso <tytso@....edu>, Jan Kara <jack@...e.com>,
        Jan Kara <jack@...e.cz>, Matthew Wilcox <willy@...radead.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org, Mark Fasheh <mark@...heh.com>,
        Joseph Qi <joseph.qi@...ux.alibaba.com>,
        Joel Becker <jlbec@...lplan.org>
Subject: Re: [patch V2 4/7] fs/jbd2: Remove jbd_trylock_bh_state()

On Thu 01-08-19 03:01:30, Thomas Gleixner wrote:
> No users.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: linux-ext4@...r.kernel.org
> Cc: "Theodore Ts'o" <tytso@....edu>
> Cc: Jan Kara <jack@...e.com>

Right.

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  include/linux/jbd2.h |    5 -----
>  1 file changed, 5 deletions(-)
> 
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -347,11 +347,6 @@ static inline void jbd_lock_bh_state(str
>  	bit_spin_lock(BH_State, &bh->b_state);
>  }
>  
> -static inline int jbd_trylock_bh_state(struct buffer_head *bh)
> -{
> -	return bit_spin_trylock(BH_State, &bh->b_state);
> -}
> -
>  static inline int jbd_is_locked_bh_state(struct buffer_head *bh)
>  {
>  	return bit_spin_is_locked(BH_State, &bh->b_state);
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR