[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190801104014.amwvjdvabedsd5t7@e110439-lin>
Date: Thu, 1 Aug 2019 11:40:14 +0100
From: Patrick Bellasi <patrick.bellasi@....com>
To: Michal Koutný <mkoutny@...e.com>
Cc: cgroups@...r.kernel.org, linux-api@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
Alessio Balsini <balsini@...roid.com>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Morten Rasmussen <morten.rasmussen@....com>,
Quentin Perret <quentin.perret@....com>,
Joel Fernandes <joelaf@...gle.com>,
Paul Turner <pjt@...gle.com>,
Steve Muckle <smuckle@...gle.com>,
Suren Baghdasaryan <surenb@...gle.com>,
Todd Kjos <tkjos@...gle.com>,
Peter Zijlstra <peterz@...radead.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
Tejun Heo <tj@...nel.org>,
Vincent Guittot <vincent.guittot@...aro.org>,
Viresh Kumar <viresh.kumar@...aro.org>,
Juri Lelli <juri.lelli@...hat.com>,
Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH v12 1/6] sched/core: uclamp: Extend CPU's cgroup
controller
On 25-Jul 13:41, Michal Koutný wrote:
> On Thu, Jul 18, 2019 at 07:17:43PM +0100, Patrick Bellasi <patrick.bellasi@....com> wrote:
> > +static ssize_t cpu_uclamp_min_write(struct kernfs_open_file *of,
> > + char *buf, size_t nbytes,
> > + loff_t off)
> > +{
> > [...]
> > +static ssize_t cpu_uclamp_max_write(struct kernfs_open_file *of,
> > + char *buf, size_t nbytes,
> > + loff_t off)
> > +{
> > [...]
> These two functions are almost identical yet not trivial. I think it
> wouldn be better to have the code at one place only and distinguish by
> the passed clamp_id.
Good point, since the removal of the boundary checks on values we now
have two identical methods. I'll factor our the common code in a
single function.
Cheers,
Patrick
--
#include <best/regards.h>
Patrick Bellasi
Powered by blists - more mailing lists