linux-kernel - Re: [PATCH v3] mailbox: imx: add support for imx v1 mu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZCz=fu7-2PmH+RGgnRgzeDCeR+A+wPbhjq2wQ2CZ3oQYg@mail.gmail.com>
Date:   Thu, 1 Aug 2019 17:47:17 +0300
From:   Daniel Baluta <daniel.baluta@...il.com>
To:     Richard Zhu <hongxing.zhu@....com>
Cc:     jassisinghbrar@...il.com, Oleksij Rempel <o.rempel@...gutronix.de>,
        Aisheng Dong <aisheng.dong@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH v3] mailbox: imx: add support for imx v1 mu

Hi Richard,

Thanks for the patch. Please always add linux-imx@....com mailing
list for imx related patches. I missed it.

Few comments inline.

Please also update in a separate patch attached to this series
the devictree bindings doc Documentation/devicetree/bindings/mailbox/fsl,mu.txt
by adding description for mx7ulp-mu

<snip>

> There is a version1.0 MU on i.MX7ULP platform.

space between version and 1.0

> One new version ID register is added, and it's offset is 0.
> TRn registers are defined at the offset 0x20 ~ 0x2C.
> RRn registers are defined at the offset 0x40 ~ 0x4C.
> SR/CR registers are defined at 0x60/0x64.
> Extend this driver to support it.

Do you have a little bit of history about MU versioning? So there was:

* version 0.5 on i.MX6-es
* version 1.0 on i.MX7ULP

Next, is this 1.0 compatbile with i.MX8 right?

Also, can you please rebase your patch on my 2 bugfixes attached?

thanks,
Daniel.

View attachment "0002-mailbox-imx-Clear-the-right-interrupts-at-shutdown.patch" of type "text/x-patch" (1275 bytes)

View attachment "0001-mailbox-imx-Fix-Tx-doorbell-shutdown-path.patch" of type "text/x-patch" (2937 bytes)