linux-kernel - Re: [PATCH v4] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190801145050.GA154523@google.com>
Date:   Thu, 1 Aug 2019 08:50:50 -0600
From:   Raul Rangel <rrangel@...omium.org>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     Tzung-Bi Shih <tzungbi@...gle.com>, bleung@...omium.org,
        groeck@...omium.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jimmy Cheng-Yi Chiang <cychiang@...gle.com>,
        Dylan Reid <dgreid@...gle.com>
Subject: Re: [PATCH v4] platform/chrome: cros_ec_trace: update generating
 script

On Thu, Aug 01, 2019 at 03:30:53PM +0200, Enric Balletbo i Serra wrote:
 
> Got it. I don't think this is a "kernel" way to do it. Also, I don't see a big
> value on doing this.

Code generation sounds great, but it makes finding and looking at the
source file difficult unless you have a build. It also makes Go to
definition in my editor fail to find the symbols since they don't exist
in the source tree.
> 
> Note also that actually, we want:
> 
> - cros_ec_commands (kernel) sync with ec_commands (EC firmware)
> - cros_ec_commands (kernel) sync with cros_ec_trace (kernel)
> 
> Hopefully we will have all sync soon.

That would be great if you synced the commands from the EC firmware :)

Thanks