linux-kernel - Re: [PATCH] platform: x86: pcengines-apu2: wire up simswitch gpio as led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 1 Aug 2019 18:01:13 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH] platform: x86: pcengines-apu2: wire up simswitch gpio as led

On Mon, Jul 29, 2019 at 5:39 PM Enrico Weigelt, metux IT consult
<info@...ux.net> wrote:
>
> From: Enrico Weigelt <info@...ux.net>
>
> The APU3+ boards have two SIM sockets, while only one of them
> can be routed to the mpcie slots at a time. Selection is done
> via simswap gpio.
>
> We currently don't have a fitting subsystem for those cases yet,
> so just wire it up to a LED for the time being. While this isn't
> really semantically correct, it's a good compromise.
>

Applied, thanks!

> Signed-off-by: Enrico Weigelt <info@...ux.net>
> ---
>  drivers/platform/x86/pcengines-apuv2.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
> index b0d3110..adecd6a 100644
> --- a/drivers/platform/x86/pcengines-apuv2.c
> +++ b/drivers/platform/x86/pcengines-apuv2.c
> @@ -69,7 +69,8 @@
>  static const struct gpio_led apu2_leds[] = {
>         { .name = "apu:green:1" },
>         { .name = "apu:green:2" },
> -       { .name = "apu:green:3" }
> +       { .name = "apu:green:3" },
> +       { .name = "apu:simswap" },
>  };
>
>  static const struct gpio_led_platform_data apu2_leds_pdata = {
> @@ -86,6 +87,8 @@
>                                 NULL, 1, GPIO_ACTIVE_LOW),
>                 GPIO_LOOKUP_IDX(AMD_FCH_GPIO_DRIVER_NAME, APU2_GPIO_LINE_LED3,
>                                 NULL, 2, GPIO_ACTIVE_LOW),
> +               GPIO_LOOKUP_IDX(AMD_FCH_GPIO_DRIVER_NAME, APU2_GPIO_REG_SIMSWAP,
> +                               NULL, 3, GPIO_ACTIVE_LOW),
>         }
>  };
>
> --
> 1.9.1
>


-- 
With Best Regards,
Andy Shevchenko