linux-kernel - Re: [PATCH] mm: fix typo in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190801155542.GJ4700@bombadil.infradead.org>
Date:   Thu, 1 Aug 2019 08:55:42 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     Joel Savitz <jsavitz@...hat.com>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Vlastimil Babka <vbabka@...e.cz>,
        Randy Dunlap <rdunlap@...radead.org>,
        Yu Zhao <yuzhao@...gle.com>, trivial@...nel.org
Subject: Re: [PATCH] mm: fix typo in comment

On Thu, Aug 01, 2019 at 11:47:34AM -0400, Joel Savitz wrote:
> Fix spelling of successful (currently spelled successfull in kernel
> source)

If you're going to bother fixing the spelling, may as well fix the grammar
at the same time.

>  	/*
> -	 * The full zone was compacted scanned but wasn't successfull to compact
> +	 * The full zone was compacted scanned but wasn't successful to compact
>  	 * suitable pages.
>  	 */

... actually, I don't know what is meant here.  Could it mean:

	/*
	 * The full zone was scanned for compaction, but didn't produce
	 * suitable pages.
	 */

>  	/*
> -	 * direct compaction has scanned part of the zone but wasn't successfull
> +	 * direct compaction has scanned part of the zone but wasn't successful
>  	 * to compact suitable pages.

	 * Zone compaction had to stop before scanning the full zone, and
	 * no suitable pages were produced.