linux-kernel - RE: [PATCH] ACPI: PM: Fix regression in acpi_device_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9cdfa1cd722e48a789a114a3d805cdfa@AUSX13MPC105.AMER.DELL.COM>
Date:   Thu, 1 Aug 2019 19:06:25 +0000
From:   <Mario.Limonciello@...l.com>
To:     <kai.heng.feng@...onical.com>, <rjw@...ysocki.net>
CC:     <linux-acpi@...r.kernel.org>, <linux-pm@...r.kernel.org>,
        <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <mika.westerberg@...ux.intel.com>, <helgaas@...nel.org>
Subject: RE: [PATCH] ACPI: PM: Fix regression in acpi_device_set_power()

> -----Original Message-----
> From: Kai-Heng Feng <kai.heng.feng@...onical.com>
> Sent: Thursday, August 1, 2019 1:11 AM
> To: Rafael J. Wysocki
> Cc: Linux ACPI; Linux PM; Linux PCI; LKML; Mika Westerberg; Bjorn Helgaas;
> Limonciello, Mario
> Subject: Re: [PATCH] ACPI: PM: Fix regression in acpi_device_set_power()
> 
> 
> at 07:31, Rafael J. Wysocki <rjw@...ysocki.net> wrote:
> 
> > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> >
> > Commit f850a48a0799 ("ACPI: PM: Allow transitions to D0 to occur in
> > special cases") overlooked the fact that acpi_power_transition() may
> > change the power.state value for the target device and if that
> > happens, it may confuse acpi_device_set_power() and cause it to
> > omit the _PS0 evaluation which on some systems is necessary to
> > change power states of devices from low-power to D0.
> >
> > Fix that by saving the current value of power.state for the
> > target device before passing it to acpi_power_transition() and
> > using the saved value in a subsequent check.
> >
> > Fixes: f850a48a0799 ("ACPI: PM: Allow transitions to D0 to occur in
> > special cases")
> > Reported-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> > Reported-by: Mario Limonciello <mario.limonciello@...l.com>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Tested-by: Kai-Heng Feng <kai.heng.feng@...onical.com>

Tested-by: Mario Limonciello <mario.limonciello@...l.com>

> 
> > ---
> >  drivers/acpi/device_pm.c |    4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > Index: linux-pm/drivers/acpi/device_pm.c
> >
> ==============================================================
> =====
> > --- linux-pm.orig/drivers/acpi/device_pm.c
> > +++ linux-pm/drivers/acpi/device_pm.c
> > @@ -236,13 +236,15 @@ int acpi_device_set_power(struct acpi_de
> >  		if (device->power.flags.power_resources)
> >  			result = acpi_power_transition(device, target_state);
> >  	} else {
> > +		int cur_state = device->power.state;
> > +
> >  		if (device->power.flags.power_resources) {
> >  			result = acpi_power_transition(device, ACPI_STATE_D0);
> >  			if (result)
> >  				goto end;
> >  		}
> >
> > -		if (device->power.state == ACPI_STATE_D0) {
> > +		if (cur_state == ACPI_STATE_D0) {
> >  			int psc;
> >
> >  			/* Nothing to do here if _PSC is not present. */
>