linux-kernel - Re: [PATCH 8/9] phy: ti: am654-serdes: Don't reference clk_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85f4dd66-0e99-7ecf-5b18-ad1715520ceb@ti.com>
Date:   Fri, 2 Aug 2019 18:15:55 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        Roger Quadros <rogerq@...com>
Subject: Re: [PATCH 8/9] phy: ti: am654-serdes: Don't reference clk_init_data
 after registration



On 01/08/19 1:05 AM, Stephen Boyd wrote:
> A future patch is going to change semantics of clk_register() so that
> clk_hw::init is guaranteed to be NULL after a clk is registered. Avoid
> referencing this member here so that we don't run into NULL pointer
> exceptions.
> 
> Cc: Roger Quadros <rogerq@...com>
> Cc: Kishon Vijay Abraham I <kishon@...com>
> Signed-off-by: Stephen Boyd <sboyd@...nel.org>
> ---
> 
> Please ack so I can take this through clk tree

Acked-by: Kishon Vijay Abraham I <kishon@...com>
> 
>  drivers/phy/ti/phy-am654-serdes.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/ti/phy-am654-serdes.c b/drivers/phy/ti/phy-am654-serdes.c
> index f8edd0840fa2..398a8c9b675a 100644
> --- a/drivers/phy/ti/phy-am654-serdes.c
> +++ b/drivers/phy/ti/phy-am654-serdes.c
> @@ -335,6 +335,7 @@ static int serdes_am654_clk_mux_set_parent(struct clk_hw *hw, u8 index)
>  {
>  	struct serdes_am654_clk_mux *mux = to_serdes_am654_clk_mux(hw);
>  	struct regmap *regmap = mux->regmap;
> +	const char *name = clk_hw_get_name(hw);
>  	unsigned int reg = mux->reg;
>  	int clk_id = mux->clk_id;
>  	int parents[SERDES_NUM_CLOCKS];
> @@ -374,8 +375,7 @@ static int serdes_am654_clk_mux_set_parent(struct clk_hw *hw, u8 index)
>  		 * This can never happen, unless we missed
>  		 * a valid combination in serdes_am654_mux_table.
>  		 */
> -		WARN(1, "Failed to find the parent of %s clock\n",
> -		     hw->init->name);
> +		WARN(1, "Failed to find the parent of %s clock\n", name);
>  		return -EINVAL;
>  	}
>  
>