[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190802134801.GK151852@google.com>
Date: Fri, 2 Aug 2019 08:48:01 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc: linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] PCI: Mark expected switch fall-through
On Thu, Aug 01, 2019 at 08:22:48PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning (Building: allmodconfig i386):
>
> drivers/pci/hotplug/ibmphp_res.c: In function ‘update_bridge_ranges’:
> drivers/pci/hotplug/ibmphp_res.c:1943:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
> function = 0x8;
> ~~~~~~~~~^~~~~
> drivers/pci/hotplug/ibmphp_res.c:1944:6: note: here
> case PCI_HEADER_TYPE_MULTIBRIDGE:
> ^~~~
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
Applied with Kees' reviewed-by to pci/misc for v5.4, thanks, Gustavo!
> ---
> drivers/pci/hotplug/ibmphp_res.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/hotplug/ibmphp_res.c b/drivers/pci/hotplug/ibmphp_res.c
> index 5e8caf7a4452..1e1ba66cfd1e 100644
> --- a/drivers/pci/hotplug/ibmphp_res.c
> +++ b/drivers/pci/hotplug/ibmphp_res.c
> @@ -1941,6 +1941,7 @@ static int __init update_bridge_ranges(struct bus_node **bus)
> break;
> case PCI_HEADER_TYPE_BRIDGE:
> function = 0x8;
> + /* Fall through */
> case PCI_HEADER_TYPE_MULTIBRIDGE:
> /* We assume here that only 1 bus behind the bridge
> TO DO: add functionality for several:
> --
> 2.22.0
>
Powered by blists - more mailing lists