linux-kernel - Re: [PATCH] fs/ceph: don't return a value from void function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 02 Aug 2019 12:32:37 -0400
From:   Jeff Layton <jlayton@...nel.org>
To:     john.hubbard@...il.com
Cc:     Sage Weil <sage@...hat.com>, Ilya Dryomov <idryomov@...il.com>,
        ceph-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
        John Hubbard <jhubbard@...dia.com>
Subject: Re: [PATCH] fs/ceph: don't return a value from void function

On Thu, 2019-08-01 at 18:06 -0700, john.hubbard@...il.com wrote:
> From: John Hubbard <jhubbard@...dia.com>
> 
> This fixes a build warning to that effect.
> 
> Signed-off-by: John Hubbard <jhubbard@...dia.com>
> ---
> 
> Hi,
> 
> I ran into this while working on unrelated changes, to
> convert ceph over to put_user_page().
> 
> This patch is against the latest linux.git.
> 
> thanks,
> John Hubbard
> NVIDIA
> 
> 
>  fs/ceph/debugfs.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
> index 2eb88ed22993..facb387c2735 100644
> --- a/fs/ceph/debugfs.c
> +++ b/fs/ceph/debugfs.c
> @@ -294,7 +294,6 @@ void ceph_fs_debugfs_init(struct ceph_fs_client *fsc)
>  
>  void ceph_fs_debugfs_init(struct ceph_fs_client *fsc)
>  {
> -	return 0;
>  }
>  
>  void ceph_fs_debugfs_cleanup(struct ceph_fs_client *fsc)

Thanks. Merged into ceph-client/testing branch, we'll see about getting
this to Linus before v5.3 ships.
-- 
Jeff Layton <jlayton@...nel.org>