linux-kernel - Re: [PATCH 7/7] tracing: Un-export ftrace_set_clr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190802134229.2a969047@gandalf.local.home>
Date:   Fri, 2 Aug 2019 13:42:28 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Divya Indi <divya.indi@...cle.com>
Cc:     linux-kernel@...r.kernel.org, Joe Jin <joe.jin@...cle.com>,
        Aruna Ramakrishna <aruna.ramakrishna@...cle.com>,
        Srinivas Eeda <srinivas.eeda@...cle.com>
Subject: Re: [PATCH 7/7] tracing: Un-export ftrace_set_clr_event

On Tue, 30 Jul 2019 15:29:41 -0700
Divya Indi <divya.indi@...cle.com> wrote:

> Hi Steven,
> 
> On 7/29/19 5:51 PM, Steven Rostedt wrote:
> > On Mon, 29 Jul 2019 17:02:34 -0700
> > Divya Indi <divya.indi@...cle.com> wrote:
> >  
> >> Use "trace_array_set_clr_event" to enable/disable events to a trace
> >> array from other kernel modules/components.
> >> Hence, we no longer need to have ftrace_set_clr_event as an exported API.  
> > Hmm, this simply reverts patch 1. Why have patch 1 and this patch in
> > the first place?  
> 
> Right! First patch fixes issues in a previous commit and then this patch 
> reverts the part of previous commit that required the fix.
> 
> We can eliminate the first patch if it seems counter intuitive.
> 
> 

As a stand alone patch, the first one may be fine. But as part of a
series, it doesn't make sense to add it.

-- Steve