linux-kernel - Re: linux-next: build warning after merge of the i2c tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190802060440.GA11858@taurus.defre.kleine-koenig.org>
Date:   Fri, 2 Aug 2019 08:04:41 +0200
From:   Uwe Kleine-König <uwe@...ine-koenig.org>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: linux-next: build warning after merge of the i2c tree

Hello Wolfram,

On Fri, Aug 02, 2019 at 01:21:23PM +1000, Stephen Rothwell wrote:
> After merging the i2c tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/i2c/busses/i2c-designware-master.c: In function 'i2c_dw_init_recovery_info':
> drivers/i2c/busses/i2c-designware-master.c:658:6: warning: unused variable 'r' [-Wunused-variable]
>   int r;
>       ^
> 
> Introduced by commit
> 
>   33eb09a02e8d ("i2c: designware: make use of devm_gpiod_get_optional")

The obvious fix is to just remove this variable. Should I send a new
patch, or do you fix up locally?

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)