linux-kernel - Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add SC7180 pinctrl binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b468e53a-d010-d95f-de9a-62ef60083074@codeaurora.org>
Date:   Fri, 2 Aug 2019 12:23:19 +0530
From:   Rajendra Nayak <rnayak@...eaurora.org>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     linus.walleij@...aro.org, bjorn.andersson@...aro.org,
        linux-arm-msm@...r.kernel.org, agross@...nel.org,
        robh+dt@...nel.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jitendra Sharma <shajit@...eaurora.org>,
        Vivek Gautam <vivek.gautam@...eaurora.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add SC7180 pinctrl
 binding



On 8/2/2019 12:03 PM, Vinod Koul wrote:
> On 02-08-19, 09:45, Rajendra Nayak wrote:
>> From: Jitendra Sharma <shajit@...eaurora.org>
>>
>> Add the binding for the TLMM pinctrl block found in the SC7180 platform
>>
>> Signed-off-by: Jitendra Sharma <shajit@...eaurora.org>
>> Signed-off-by: Vivek Gautam <vivek.gautam@...eaurora.org>
>> [rnayak: Fix some copy-paste issues, sort and fix functions]
>> Signed-off-by: Rajendra Nayak <rnayak@...eaurora.org>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
>> ---
> 
> changes since v1: ..?
> 
>> +- reg-names:
>> +	Usage: required
>> +	Value type: <prop-encoded-array>
>> +	Defintiion: names for the cells of reg, must contain "north", "south"
> 
> s/Defintiion/Definition
> 
>> +Example:
>> +
>> +	tlmm: pinctrl@...0000 {
> 
> this should be: pinctrl@...0000
> 
> with these two nitpicks fixed:

Thanks Vinod for the review. I will fix these and respin, after I wait
a while to see if there is any more feedback :)

> 
> Reviewed-by: Vinod Koul <vkoul@...nel.org>
> 

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation