linux-kernel - Re: [PATCH 4.14 43/43] tipc: pass tunnel dev as NULL to udp_tunnel(6)_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190802072834.GC26174@kroah.com>
Date:   Fri, 2 Aug 2019 09:28:34 +0200
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     "Rantala, Tommi T. (Nokia - FI/Espoo)" <tommi.t.rantala@...ia.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lucien.xin@...il.com" <lucien.xin@...il.com>,
        "syzbot+c4c4b2bb358bb936ad7e@...kaller.appspotmail.com" 
        <syzbot+c4c4b2bb358bb936ad7e@...kaller.appspotmail.com>,
        "syzbot+a43d8d4e7e8a7a9e149e@...kaller.appspotmail.com" 
        <syzbot+a43d8d4e7e8a7a9e149e@...kaller.appspotmail.com>,
        "syzbot+a47c5f4c6c00fc1ed16e@...kaller.appspotmail.com" 
        <syzbot+a47c5f4c6c00fc1ed16e@...kaller.appspotmail.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "syzbot+a9e23ea2aa21044c2798@...kaller.appspotmail.com" 
        <syzbot+a9e23ea2aa21044c2798@...kaller.appspotmail.com>,
        "syzbot+0290d2290a607e035ba1@...kaller.appspotmail.com" 
        <syzbot+0290d2290a607e035ba1@...kaller.appspotmail.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "syzbot+9d4c12bfd45a58738d0a@...kaller.appspotmail.com" 
        <syzbot+9d4c12bfd45a58738d0a@...kaller.appspotmail.com>
Subject: Re: [PATCH 4.14 43/43] tipc: pass tunnel dev as NULL to
 udp_tunnel(6)_xmit_skb

On Thu, Aug 01, 2019 at 10:17:30AM +0000, Rantala, Tommi T. (Nokia - FI/Espoo) wrote:
> On Tue, 2019-07-02 at 10:02 +0200, Greg Kroah-Hartman wrote:
> > From: Xin Long <lucien.xin@...il.com>
> > 
> > commit c3bcde026684c62d7a2b6f626dc7cf763833875c upstream.
> > 
> > udp_tunnel(6)_xmit_skb() called by tipc_udp_xmit() expects a tunnel
> > device
> > to count packets on dev->tstats, a perpcu variable. However, TIPC is
> > using
> > udp tunnel with no tunnel device, and pass the lower dev, like veth
> > device
> > that only initializes dev->lstats(a perpcu variable) when creating
> > it.
> 
> Hi,
> 
> This tipc patch added in 4.14.132 is triggering a crash for me, revert
> fixes it.
> 
> Anyone have ideas if some other commits missing in 4.14.x to make this
> work...?

Do you also hav a problem with 4.19.y?  How about 5.2.y?  If not, can
you do 'git bisect' to find the patch that fixes the issue?

thanks,

greg k-h