Date:   Fri, 2 Aug 2019 09:51:24 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ajay Kaher <akaher@...are.com>
Cc:     aarcange@...hat.com, jannh@...gle.com, oleg@...hat.com,
        peterx@...hat.com, rppt@...ux.ibm.com, jgg@...lanox.com,
        mhocko@...e.com, jglisse@...hat.com, akpm@...ux-foundation.org,
        mike.kravetz@...cle.com, viro@...iv.linux.org.uk,
        riandrews@...roid.com, arve@...roid.com, yishaih@...lanox.com,
        dledford@...hat.com, sean.hefty@...el.com,
        hal.rosenstock@...il.com, matanb@...lanox.com, leonro@...lanox.com,
        torvalds@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
        linux-mm@...ck.org, devel@...verdev.osuosl.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, srivatsab@...are.com, amakhalov@...are.com
Subject: Re: [PATCH v5 1/3] [v4.9.y] coredump: fix race condition between
 mmget_not_zero()/get_task_mm() and core dumping

On Tue, Jul 02, 2019 at 12:02:05AM +0530, Ajay Kaher wrote:
> From: Andrea Arcangeli <aarcange@...hat.com>
> 
> commit 04f5866e41fb70690e28397487d8bd8eea7d712a upstream.
> 
> The core dumping code has always run without holding the mmap_sem for
> writing, despite that is the only way to ensure that the entire vma
> layout will not change from under it.  Only using some signal
> serialization on the processes belonging to the mm is not nearly enough.
> This was pointed out earlier.  For example in Hugh's post from Jul 2017:
> 
>   https://lkml.kernel.org/r/alpine.LSU.2.11.1707191716030.2055@eggly.anvils
> 
>   "Not strictly relevant here, but a related note: I was very surprised
>    to discover, only quite recently, how handle_mm_fault() may be called
>    without down_read(mmap_sem) - when core dumping. That seems a
>    misguided optimization to me, which would also be nice to correct"
> 
> In particular because the growsdown and growsup can move the
> vm_start/vm_end the various loops the core dump does around the vma will
> not be consistent if page faults can happen concurrently.
> 
> Pretty much all users calling mmget_not_zero()/get_task_mm() and then
> taking the mmap_sem had the potential to introduce unexpected side
> effects in the core dumping code.
> 
> Adding mmap_sem for writing around the ->core_dump invocation is a
> viable long term fix, but it requires removing all copy user and page
> faults and to replace them with get_dump_page() for all binary formats
> which is not suitable as a short term fix.
> 
> For the time being this solution manually covers the places that can
> confuse the core dump either by altering the vma layout or the vma flags
> while it runs.  Once ->core_dump runs under mmap_sem for writing the
> function mmget_still_valid() can be dropped.
> 
> Allowing mmap_sem protected sections to run in parallel with the
> coredump provides some minor parallelism advantage to the swapoff code
> (which seems to be safe enough by never mangling any vma field and can
> keep doing swapins in parallel to the core dumping) and to some other
> corner case.
> 
> In order to facilitate the backporting I added "Fixes: 86039bd3b4e6"
> however the side effect of this same race condition in /proc/pid/mem
> should be reproducible since before 2.6.12-rc2 so I couldn't add any
> other "Fixes:" because there's no hash beyond the git genesis commit.
> 
> Because find_extend_vma() is the only location outside of the process
> context that could modify the "mm" structures under mmap_sem for
> reading, by adding the mmget_still_valid() check to it, all other cases
> that take the mmap_sem for reading don't need the new check after
> mmget_not_zero()/get_task_mm().  The expand_stack() in page fault
> context also doesn't need the new check, because all tasks under core
> dumping are frozen.
> 
> Link: http://lkml.kernel.org/r/20190325224949.11068-1-aarcange@redhat.com
> Fixes: 86039bd3b4e6 ("userfaultfd: add new syscall to provide memory externalization")
> Signed-off-by: Andrea Arcangeli <aarcange@...hat.com>
> Reported-by: Jann Horn <jannh@...gle.com>
> Suggested-by: Oleg Nesterov <oleg@...hat.com>
> Acked-by: Peter Xu <peterx@...hat.com>
> Reviewed-by: Mike Rapoport <rppt@...ux.ibm.com>
> Reviewed-by: Oleg Nesterov <oleg@...hat.com>
> Reviewed-by: Jann Horn <jannh@...gle.com>
> Acked-by: Jason Gunthorpe <jgg@...lanox.com>
> Acked-by: Michal Hocko <mhocko@...e.com>
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> [akaher@...are.com: stable 4.9 backport
> -  handle binder_update_page_range - mhocko@...e.com]
> Signed-off-by: Ajay Kaher <akaher@...are.com>
> ---
> drivers/android/binder.c |  6 ++++++
> fs/proc/task_mmu.c       | 18 ++++++++++++++++++
> fs/userfaultfd.c         |  9 +++++++++
> include/linux/mm.h       | 21 +++++++++++++++++++++
> mm/mmap.c                |  6 +++++-
> 5 files changed, 59 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 80499f4..f05ab8f 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -581,6 +581,12 @@ static int binder_update_page_range(struct binder_proc *proc, int allocate,
> 	if (mm) {
> 		down_write(&mm->mmap_sem);
> +		if (!mmget_still_valid(mm)) {
> +			if (allocate == 0)
> +				goto free_range;
> +			goto err_no_vma;
> +		}
> +
> 		vma = proc->vma;
> 		if (vma && mm != proc->vma_vm_mm) {
> 			pr_err("%d: vma mm and task mm mismatch\n",
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 5138e78..4b207b1 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -1057,6 +1057,24 @@ static ssize_t clear_refs_write(struct file *file, const char __user *buf,

This patch is oddly corrupted, and I can't figure out how to fix it up.

When applying it, I get following error:

patching file drivers/android/binder.c
patch: **** malformed patch at line 102: diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c

So something is odd here.

Can you please fix this up, and resend the series so that they can be
applied?

thanks,

greg k-h

Powered by blists - more mailing lists