linux-kernel - Re: [PATCH v4 1/2] kernel.h: Update comment about simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcjgGymKsxouv_oDcwVnUp8Yc1Pi_rmi09yLnwtMsz4kQ@mail.gmail.com>
Date:   Fri, 2 Aug 2019 10:55:51 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Mans Rullgard <mans@...sr.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Petr Mladek <pmladek@...e.com>
Subject: Re: [PATCH v4 1/2] kernel.h: Update comment about simple_strto<foo>() functions

On Fri, Aug 2, 2019 at 4:47 AM Joe Perches <joe@...ches.com> wrote:
> On Thu, 2019-08-01 at 22:29 +0300, Andy Shevchenko wrote:

> >   * Returns 0 on success, -ERANGE on overflow and -EINVAL on parsing error.
> > - * Used as a replacement for the obsolete simple_strtoull. Return code must
> > - * be checked.
> > + * Used as a replacement for the simple_strtoull. Return code must be checked.
>
> Using 'the' here is unnecessary and somewhat confusing.
>
> Perhaps:
>
>  * Preferred over simple_strtoull() unless the end position is required
>  * Return value must be checked

IIRC it simple returns back to the original comment.

-- 
With Best Regards,
Andy Shevchenko