linux-kernel - Re: [PATCH] ext4: use rb_entry_safe() instead of open-coding it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190802110233.GB9339@quack2.suse.cz>
Date:   Fri, 2 Aug 2019 13:02:33 +0200
From:   Jan Kara <jack@...e.cz>
To:     Weitao Hou <houweitaoo@...il.com>
Cc:     tytso@....edu, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: use rb_entry_safe() instead of open-coding it

On Thu 25-07-19 21:16:58, Weitao Hou wrote:
> use rb_entry_safe() to make it clean
> 
> Signed-off-by: Weitao Hou <houweitaoo@...il.com>

Thanks for the patch. It looks good. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext4/extents_status.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c
> index 7521de2dcf3a..08ce5ded3538 100644
> --- a/fs/ext4/extents_status.c
> +++ b/fs/ext4/extents_status.c
> @@ -228,8 +228,7 @@ static struct extent_status *__es_tree_search(struct rb_root *root,
>  
>  	if (es && lblk > ext4_es_end(es)) {
>  		node = rb_next(&es->rb_node);
> -		return node ? rb_entry(node, struct extent_status, rb_node) :
> -			      NULL;
> +		return rb_entry_safe(node, struct extent_status, rb_node);
>  	}
>  
>  	return NULL;
> -- 
> 2.18.0
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR