linux-kernel - Re: [PATCH] drm/imx: Drop unused imx-ipuv3-crtc.o build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1564747425.3090.1.camel@pengutronix.de>
Date:   Fri, 02 Aug 2019 14:03:45 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Fabio Estevam <festevam@...il.com>,
        Guido Günther <agx@...xcpu.org>
Cc:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        DRI mailing list <dri-devel@...ts.freedesktop.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/imx: Drop unused imx-ipuv3-crtc.o build

Hi Guido, Fabio,

On Fri, 2019-08-02 at 08:03 -0300, Fabio Estevam wrote:
> Hi Guido,
> 
> Good catch!
> 
> On Fri, Aug 2, 2019 at 7:55 AM Guido Günther <agx@...xcpu.org> wrote:
> > 
> > Since
> > 
> > commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
> > 
> > imx-ipuv3-crtc.o is built via imxdrm-objs. So there's no need to keep an
> 
> Actually, it is ipuv3-crtc.o that is built via imxdrm-objs, not
> imx-ipuv3-crtc.o.
> 
> Apart from that:
> 
> Reviewed-by: Fabio Estevam <festevam@...il.com>

Thank you, applied to imx-drm/next with Fabio's R-b, and added Fixes:
tag, and the commit message changed as follows:

    drm/imx: Drop unused imx-ipuv3-crtc.o build
    
    Since
    
    commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
    
    the former contents of imx-ipuv3-crtc.o are built via imxdrm-objs. So
    there's no need to keep an extra entry with a non existing config value
    (CONFIG_DRM_IMX_IPUV3).
    
    Fixes: 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
    Signed-off-by: Guido Günther <agx@...xcpu.org>
    Reviewed-by: Fabio Estevam <festevam@...il.com>
    Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>

no action necessary if you agree, otherwise just send a v2 and I'll
replace it.

regards
Philipp