linux-kernel - Re: [PATCH AUTOSEL 4.19 06/42] scripts/sphinx-pre-install: fix script for RHEL/CentOS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 3 Aug 2019 15:09:38 +0300
From:   Alexander Kapshuk <alexander.kapshuk@...il.com>
To:     Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
Cc:     Sasha Levin <sashal@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "# 3.9+" <stable@...r.kernel.org>
Subject: Re: [PATCH AUTOSEL 4.19 06/42] scripts/sphinx-pre-install: fix script
 for RHEL/CentOS

On Sat, Aug 3, 2019 at 1:37 PM Mauro Carvalho Chehab
<mchehab+samsung@...nel.org> wrote:
>
> Em Sat, 3 Aug 2019 13:31:30 +0300
> Alexander Kapshuk <alexander.kapshuk@...il.com> escreveu:
>
> > > -       if (! $system_release =~ /Fedora/) {
> > > +       if (!($system_release =~ /Fedora/)) {
> > >                 $map{"virtualenv"} = "python-virtualenv";
> > >         }
> >
> > The negated binding operator '!~' could be used here as well, and it
> > does not require the use of extra parenthesis.
> > Just a thought.
>
> Thanks for the tip! Never used such operator. Will start using
> next time we need to handle a pattern like that.
>
> Thanks,
> Mauro

No worries at all.