linux-kernel - Re: [PATCH] arch/alpha: Remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFqt6zb5phXBZCVwLVcRBQ8hqdMQ-SLX0q4jgTJu-vwHXH_A1A@mail.gmail.com>
Date:   Sun, 4 Aug 2019 01:20:04 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     rth@...ddle.net, ink@...assic.park.msu.ru,
        Matt Turner <mattst88@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        rppt@...ux.vnet.ibm.com, Michal Hocko <mhocko@...e.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Michael Ellerman <mpe@...erman.id.au>,
        Paul Burton <paul.burton@...s.com>,
        Colin King <colin.king@...onical.com>,
        Greg KH <gregkh@...uxfoundation.org>, rfontana@...hat.com,
        Thomas Gleixner <tglx@...utronix.de>,
        Arnd Bergmann <arnd@...db.de>, firoz.khan@...aro.org,
        Jann Horn <jannh@...gle.com>, namit@...are.com,
        linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch/alpha: Remove dead code

On Sun, Aug 4, 2019 at 12:50 AM Al Viro <viro@...iv.linux.org.uk> wrote:
>
> On Sun, Aug 04, 2019 at 12:47:36AM +0530, Souptick Joarder wrote:
> > These are dead code since 2.6.11. If there is no plan to use
> > it further, this can be removed forever.
>
> What's the point in removing ifdefed-out debugging printks?

If those debugging printks are kept under "#if 0" purposefully, then those
can be left as it is. Other parts are under "if 0" can be removed as those are
not used since 2.6.11.

How about keeping those debugging printk under some CONFIG_*_DEBUG option ?

While browsing source code, I figure out there are huge amount of dead
code under
'#if 0"  and some of them are maintained since 2.6.* . I send few
similar patches for fbdev
driver and those are merged to linux-next.
But how about cleaning it in entire tree ( module wise) ? Does it make sense ?