linux-kernel - Re: [PATCH 10/34] genwqe: convert put_page() to put_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 3 Aug 2019 09:06:40 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     john.hubbard@...il.com
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-fbdev@...r.kernel.org, Jan Kara <jack@...e.cz>,
        kvm@...r.kernel.org, Dave Hansen <dave.hansen@...ux.intel.com>,
        Dave Chinner <david@...morbit.com>,
        dri-devel@...ts.freedesktop.org, linux-mm@...ck.org,
        sparclinux@...r.kernel.org, ceph-devel@...r.kernel.org,
        devel@...verdev.osuosl.org, rds-devel@....oracle.com,
        linux-rdma@...r.kernel.org, x86@...nel.org,
        amd-gfx@...ts.freedesktop.org,
        Christoph Hellwig <hch@...radead.org>,
        Jason Gunthorpe <jgg@...pe.ca>, xen-devel@...ts.xenproject.org,
        devel@...ts.orangefs.org, linux-media@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>,
        "Guilherme G. Piccoli" <gpiccoli@...ux.vnet.ibm.com>,
        John Hubbard <jhubbard@...dia.com>,
        intel-gfx@...ts.freedesktop.org, linux-block@...r.kernel.org,
        Jérôme Glisse <jglisse@...hat.com>,
        linux-rpi-kernel@...ts.infradead.org,
        Dan Williams <dan.j.williams@...el.com>,
        linux-arm-kernel@...ts.infradead.org, linux-nfs@...r.kernel.org,
        netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        linux-xfs@...r.kernel.org, linux-crypto@...r.kernel.org,
        linux-fsdevel@...r.kernel.org,
        Frank Haverkamp <haver@...ux.vnet.ibm.com>
Subject: Re: [PATCH 10/34] genwqe: convert put_page() to put_user_page*()

On Thu, Aug 01, 2019 at 07:19:41PM -0700, john.hubbard@...il.com wrote:
> From: John Hubbard <jhubbard@...dia.com>
> 
> For pages that were retained via get_user_pages*(), release those pages
> via the new put_user_page*() routines, instead of via put_page() or
> release_pages().
> 
> This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
> ("mm: introduce put_user_page*(), placeholder versions").
> 
> This changes the release code slightly, because each page slot in the
> page_list[] array is no longer checked for NULL. However, that check
> was wrong anyway, because the get_user_pages() pattern of usage here
> never allowed for NULL entries within a range of pinned pages.
> 
> Cc: Frank Haverkamp <haver@...ux.vnet.ibm.com>
> Cc: "Guilherme G. Piccoli" <gpiccoli@...ux.vnet.ibm.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: John Hubbard <jhubbard@...dia.com>
> ---
>  drivers/misc/genwqe/card_utils.c | 17 +++--------------
>  1 file changed, 3 insertions(+), 14 deletions(-)

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>