linux-kernel - Re: [PATCH AUTOSEL 4.19 06/42] scripts/sphinx-pre-install: fix script for RHEL/CentOS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 3 Aug 2019 13:31:30 +0300
From:   Alexander Kapshuk <alexander.kapshuk@...il.com>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        "# 3.9+" <stable@...r.kernel.org>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
Subject: Re: [PATCH AUTOSEL 4.19 06/42] scripts/sphinx-pre-install: fix script
 for RHEL/CentOS

On Sat, Aug 3, 2019 at 11:19 AM Sasha Levin <sashal@...nel.org> wrote:
>
> From: Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
>
> [ Upstream commit b308467c916aa7acc5069802ab76a9f657434701 ]
>
> There's a missing parenthesis at the script, with causes it to
> fail to detect non-Fedora releases (e. g. RHEL/CentOS).
>
> Tested with Centos 7.6.1810.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  scripts/sphinx-pre-install | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/sphinx-pre-install b/scripts/sphinx-pre-install
> index 067459760a7b0..3524dbc313163 100755
> --- a/scripts/sphinx-pre-install
> +++ b/scripts/sphinx-pre-install
> @@ -301,7 +301,7 @@ sub give_redhat_hints()
>         #
>         # Checks valid for RHEL/CentOS version 7.x.
>         #
> -       if (! $system_release =~ /Fedora/) {
> +       if (!($system_release =~ /Fedora/)) {
>                 $map{"virtualenv"} = "python-virtualenv";
>         }
>
> --
> 2.20.1
>

The negated binding operator '!~' could be used here as well, and it
does not require the use of extra parenthesis.
Just a thought.