linux-kernel - Re: [PATCH] staging: rtl8192e: Make use kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190804023844.GA14043@hari-Inspiron-1545>
Date:   Sun, 4 Aug 2019 08:08:44 +0530
From:   Hariprasad Kelam <hariprasad.kelam@...il.com>
To:     Joe Perches <joe@...ches.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Himadri Pandya <himadri18.07@...il.com>,
        Michiel Schuurmans <michielschuurmans@...il.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        Hariprasad Kelam <hariprasad.kelam@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: Make use kmemdup

On Sat, Aug 03, 2019 at 10:52:04AM -0700, Joe Perches wrote:
> On Sat, 2019-08-03 at 23:10 +0530, Hariprasad Kelam wrote:
> > As kmemdup API does kmalloc + memcpy . We can make use of it instead of
> > calling kmalloc and memcpy independetly.
> []
> > diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> []
> > @@ -1382,10 +1382,8 @@ rtllib_association_req(struct rtllib_network *beacon,
> >  	ieee->assocreq_ies = NULL;
> >  	ies = &(hdr->info_element[0].id);
> >  	ieee->assocreq_ies_len = (skb->data + skb->len) - ies;
> > -	ieee->assocreq_ies = kmalloc(ieee->assocreq_ies_len, GFP_ATOMIC);
> > -	if (ieee->assocreq_ies)
> > -		memcpy(ieee->assocreq_ies, ies, ieee->assocreq_ies_len);
> > -	else {
> > +	ieee->assocreq_ies = kmemdup(ies, ieee->assocreq_ies_len, GFP_ATOMIC);
> > +	if (!ieee->assocreq_ies) {
> >  		netdev_info(ieee->dev,
> >  			    "%s()Warning: can't alloc memory for assocreq_ies\n",
> >  			    __func__);
> > @@ -2259,12 +2257,10 @@ rtllib_rx_assoc_resp(struct rtllib_device *ieee, struct sk_buff *skb,
> >  			ieee->assocresp_ies = NULL;
> >  			ies = &(assoc_resp->info_element[0].id);
> >  			ieee->assocresp_ies_len = (skb->data + skb->len) - ies;
> > -			ieee->assocresp_ies = kmalloc(ieee->assocresp_ies_len,
> > +			ieee->assocresp_ies = kmemdup(ies,
> > +						      ieee->assocresp_ies_len,
> >  						      GFP_ATOMIC);
> > -			if (ieee->assocresp_ies)
> > -				memcpy(ieee->assocresp_ies, ies,
> > -				       ieee->assocresp_ies_len);
> > -			else {
> > +			if (!ieee->assocresp_ies) {
> >  				netdev_info(ieee->dev,
> >  					    "%s()Warning: can't alloc memory for assocresp_ies\n",
> >  					    __func__);
> 
> Could also remove the netdev_info() uses for allocation failures.
> These are redundant as a dump_stack() is already done when OOM.
> 
Sure will do.

Thanks,
Hariprasad k