linux-kernel - Re: [PATCH] staging: pi433 line over 80 characters in multiple places

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 5 Aug 2019 17:03:04 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Giridhar Prasath R <cristianoprasath@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: pi433 line over 80 characters in multiple places

On Mon, Aug 05, 2019 at 05:32:45AM +0530, Giridhar Prasath R wrote:
> Fix the following checkpatch warnings:
> 
> WARNING: line over 80 characters
> FILE: drivers/staging/pi433/pi433_if.h
> 
> Signed-off-by: Giridhar Prasath R <cristianoprasath@...il.com>
> ---
>  drivers/staging/pi433/pi433_if.h | 23 ++++++++++++++++-------
>  1 file changed, 16 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
> index 9feb95c431cb..915bd96910c6 100644
> --- a/drivers/staging/pi433/pi433_if.h
> +++ b/drivers/staging/pi433/pi433_if.h
> @@ -117,9 +117,14 @@ struct pi433_rx_cfg {
>  
>  	/* packet format */
>  	enum option_on_off	enable_sync;
> -	enum option_on_off	enable_length_byte;	  /* should be used in combination with sync, only */
> -	enum address_filtering	enable_address_filtering; /* operational with sync, only */
> -	enum option_on_off	enable_crc;		  /* only operational, if sync on and fixed length or length byte is used */
> +	/* should be used in combination with sync, only */
> +	enum option_on_off	enable_length_byte;
> +	/* operational with sync, only */
> +	enum address_filtering	enable_address_filtering;
> +	/* only operational,
> +	 * if sync on and fixed length or length byte is used
> +	 */
> +	enum option_on_off	enable_crc;
>  
>  	__u8			sync_length;
>  	__u8			fixed_message_length;
> @@ -132,10 +137,14 @@ struct pi433_rx_cfg {
>  
>  #define PI433_IOC_MAGIC			'r'
>  
> -#define PI433_IOC_RD_TX_CFG	_IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)])
> -#define PI433_IOC_WR_TX_CFG	_IOW(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)])
> +#define PI433_IOC_RD_TX_CFG	_IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR,\
> +char[sizeof(struct pi433_tx_cfg)])

Ick, that does not look better :(

We write code for humans first, compilers second.

The original is fine, thanks.

greg k-h