linux-kernel - Re: [PATCH v2 1/2] KVM: remove kvm_arch_has_vcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Aug 2019 17:48:15 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Radim Krm <rkrcmar@...hat.com>, kvm@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] KVM: remove kvm_arch_has_vcpu_debugfs()

On 05/08/19 17:36, Greg KH wrote:
> On Sat, Aug 03, 2019 at 08:23:25AM +0200, Paolo Bonzini wrote:
>> On 31/07/19 20:55, Greg KH wrote:
>>> There is no need for this function as all arches have to implement
>>> kvm_arch_create_vcpu_debugfs() no matter what, so just remove this call
>>> as it is pointless.
>>>
>>> Cc: Paolo Bonzini <pbonzini@...hat.com>
>>> Cc: "Radim Krm" <rkrcmar@...hat.com>
>>> Cc: Thomas Gleixner <tglx@...utronix.de>
>>> Cc: Ingo Molnar <mingo@...hat.com>
>>> Cc: Borislav Petkov <bp@...en8.de>
>>> Cc: "H. Peter Anvin" <hpa@...or.com>
>>> Cc: <x86@...nel.org>
>>> Cc: <kvm@...r.kernel.org>
>>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>>> ---
>>> v2: new patch in the series
>>
>> Let's remove kvm_arch_arch_create_vcpu_debugfs too for non-x86 arches.
>>
>> I'll queue your 2/2.
> 
> Great, so what about 1/2?  I have no objection to your patch for this.

I'll queue my own replacement of 1/2, together with your 2/2.  Both
should reach Linus later this week.

Paolo