linux-kernel - Re: [PATCH v6 28/57] pcie-gadget-spear: Remove dev_err() usage after platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190805160500.GA29507@kroah.com>
Date:   Mon, 5 Aug 2019 18:05:00 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 28/57] pcie-gadget-spear: Remove dev_err() usage after
 platform_get_irq()

On Wed, Jul 31, 2019 at 07:16:22AM -0700, Stephen Boyd wrote:
> Quoting Arnd Bergmann (2019-07-30 11:29:45)
> > On Tue, Jul 30, 2019 at 8:16 PM Stephen Boyd <swboyd@...omium.org> wrote:
> > >
> > > We don't need dev_err() messages when platform_get_irq() fails now that
> > > platform_get_irq() prints an error message itself when something goes
> > > wrong. Let's remove these prints with a simple semantic patch.
> > 
> > > Cc: Arnd Bergmann <arnd@...db.de>
> > > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> > > ---
> > >
> > > Please apply directly to subsystem trees
> > 
> > The patch looks coorrect
> > 
> > Acked-by: Arnd Bergmann <arnd@...db.de>
> > 
> > I wonder if we should just remove that driver though, it's been marked
> > as 'depends on BROKEN' since 2013, and it has never been possible
> > to compile it.
> 
> I'm happy to replace this patch with a deletion patch.
> 
> -----8<-----
> From: Stephen Boyd <swboyd@...omium.org>
> Subject: [PATCH] misc: Remove spear13xx pcie gadget driver
> 
> This driver has been marked broken since 2013, see commit 98097858ccf3
> ("misc: mark spear13xx-pcie-gadget as broken"). Let's remove this file
> now that it's been more than 5 years of existing in a broken state.
> 
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>

Good idea, I've now queued up this deletion patch instead, thanks!

greg k-h