linux-kernel - Re: [PATCH v2] drm: rcar_lvds: Fix dual link mode operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 5 Aug 2019 20:17:19 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Jacopo Mondi <jacopo+renesas@...ndi.org>
Cc:     Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        fabrizio.castro@...renesas.com,
        "open list:DRM DRIVERS FOR RENESAS" <dri-devel@...ts.freedesktop.org>,
        "open list:DRM DRIVERS FOR RENESAS" 
        <linux-renesas-soc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drm: rcar_lvds: Fix dual link mode operations

Hi Jacopo,

Thank you for the patch.

On Mon, Aug 05, 2019 at 06:18:37PM +0200, Jacopo Mondi wrote:
> The R-Car LVDS encoder units support dual-link operations by splitting
> the pixel output between the primary encoder and the companion one.

s/companion one/companion encoder/

> Currently the companion encoder fails at probe time, causing the
> registration of the primary to fail as well, preventing the whole DU unit
> from being registered at all.
> 
> Fix this by not bailing out from probe with error if the
> "renesas,companion" property is not specified.
> 
> Fixes: fa440d870358 ("drm: rcar-du: lvds: Add support for dual-link mode")
> Reported-by: Fabrizio Castro <fabrizio.castro@...renesas.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@...ndi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

and applied to my tree, thank you.

> ---
>  drivers/gpu/drm/rcar-du/rcar_lvds.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> index bada7ee98544..0b872d00760b 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> @@ -662,10 +662,8 @@ static int rcar_lvds_parse_dt_companion(struct rcar_lvds *lvds)
> 
>  	/* Locate the companion LVDS encoder for dual-link operation, if any. */
>  	companion = of_parse_phandle(dev->of_node, "renesas,companion", 0);
> -	if (!companion) {
> -		dev_err(dev, "Companion LVDS encoder not found\n");
> -		return -ENXIO;
> -	}
> +	if (!companion)
> +		return 0;
> 
>  	/*
>  	 * Sanity check: the companion encoder must have the same compatible

-- 
Regards,

Laurent Pinchart