linux-kernel - Re: [PATCH] NFC: nfcmrvl: fix gpio-handling regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190805.102656.1576923178764860652.davem@davemloft.net>
Date:   Mon, 05 Aug 2019 10:26:56 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     johan@...nel.org
Cc:     netdev@...r.kernel.org, linus.walleij@...aro.org,
        cuissard@...vell.com, andreyknvl@...gle.com, dvyukov@...gle.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org,
        syzbot+cf35b76f35e068a1107f@...kaller.appspotmail.com
Subject: Re: [PATCH] NFC: nfcmrvl: fix gpio-handling regression

From: Johan Hovold <johan@...nel.org>
Date: Mon,  5 Aug 2019 12:00:55 +0200

> Fix two reset-gpio sanity checks which were never converted to use
> gpio_is_valid(), and make sure to use -EINVAL to indicate a missing
> reset line also for the UART-driver module parameter and for the USB
> driver.
> 
> This specifically prevents the UART and USB drivers from incidentally
> trying to request and use gpio 0, and also avoids triggering a WARN() in
> gpio_to_desc() during probe when no valid reset line has been specified.
> 
> Fixes: e33a3f84f88f ("NFC: nfcmrvl: allow gpio 0 for reset signalling")
> Cc: stable <stable@...r.kernel.org>	# 4.13
> Reported-by: syzbot+cf35b76f35e068a1107f@...kaller.appspotmail.com
> Tested-by: syzbot+cf35b76f35e068a1107f@...kaller.appspotmail.com
> Signed-off-by: Johan Hovold <johan@...nel.org>

Applied and queued up for -stable.