linux-kernel - Re: [PATCH v2] PM/sleep: Expose suspend stats in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANA+-vBO-dE6kqgHZ843oMOkkQhXN=3JZLiJby4pR_E2bxd7Zg@mail.gmail.com>
Date:   Mon, 5 Aug 2019 11:29:00 -0700
From:   Tri Vo <trong@...roid.com>
To:     Kalesh Singh <kaleshsingh@...gle.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>, Tri Vo <trong@...gle.com>,
        Sandeep Patil <sspatil@...gle.com>,
        Hridya Valsaraju <hridya@...gle.com>,
        "Cc: Android Kernel" <kernel-team@...roid.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v2] PM/sleep: Expose suspend stats in sysfs

On Thu, Aug 1, 2019 at 9:34 AM Kalesh Singh <kaleshsingh@...gle.com> wrote:
>
> On Wed, Jul 31, 2019 at 11:19 PM Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> > On Wed, Jul 31, 2019 at 02:29:33PM -0700, Kalesh Singh wrote:
> > > Userspace can get suspend stats from the suspend stats debugfs node.
> > > Since debugfs doesn't have stable ABI, expose suspend stats in
> > > sysfs under /sys/power/suspend_stats.
> > >
> > > Signed-off-by: Kalesh Singh <kaleshsingh@...gle.com>
> > > ---
> > > Changes in v2:
> > >   - Added separate show functions for last_failed_* stats, as per Greg
> > >   - Updated ABI Documentation
> >
> > This is nice, I didn't even know some of these were in the debugfs
> > entries, so this should be more helpful to people.
> >
> > Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Reviewed-by: Tri Vo <trong@...roid.com>