linux-kernel - Re: [PATCH] fs/io_uring.c: convert put_page() to put_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dddaaf48-ce33-bdf4-86cb-47101d15eb6c@nvidia.com>
Date:   Mon, 5 Aug 2019 15:12:42 -0700
From:   John Hubbard <jhubbard@...dia.com>
To:     Ira Weiny <ira.weiny@...el.com>, <john.hubbard@...il.com>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        Christoph Hellwig <hch@...radead.org>, Jan Kara <jack@...e.cz>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Jerome Glisse <jglisse@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        <linux-fsdevel@...r.kernel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Jens Axboe <axboe@...nel.dk>, <linux-block@...r.kernel.org>
Subject: Re: [PATCH] fs/io_uring.c: convert put_page() to put_user_page*()

On 8/5/19 3:05 PM, Ira Weiny wrote:
> On Mon, Aug 05, 2019 at 03:04:42PM -0700, 'Ira Weiny' wrote:
>> On Sun, Aug 04, 2019 at 07:32:06PM -0700, john.hubbard@...il.com wrote:
>>> From: John Hubbard <jhubbard@...dia.com>
>>>
>>> For pages that were retained via get_user_pages*(), release those pages
>>> via the new put_user_page*() routines, instead of via put_page() or
>>> release_pages().
>>>
>>> This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
>>> ("mm: introduce put_user_page*(), placeholder versions").
>>>
>>> Cc: Alexander Viro <viro@...iv.linux.org.uk>
>>> Cc: Jens Axboe <axboe@...nel.dk>
>>> Cc: linux-fsdevel@...r.kernel.org
>>> Cc: linux-block@...r.kernel.org
>>> Signed-off-by: John Hubbard <jhubbard@...dia.com>
>>
>> Signed-off-by: Ira Weiny <ira.weiny@...el.com>
> 
> <sigh>
> 
> I meant to say I wrote the same patch ...  For this one...
> 
> Reviewed-by: Ira Weiny <ira.weiny@...el.com>
> 

Hi Ira,

Say, in case you or anyone else is up for it: there are still about 
two thirds of the 34 patches that could use a reviewed-by, in this series:

   https://lore.kernel.org/r/20190804224915.28669-1-jhubbard@nvidia.com

...and even reviewing one or two quick ones would help--no need to look at
all of them, especially if several people each look at a few.

Also note that I'm keeping the gup_dma_core branch tracking the latest
linux.git, and it seems to be working pretty well, aside from one warning
that I haven't yet figured out (as per the latest commit):

    git@...hub.com:johnhubbard/linux.git
   

thanks,
-- 
John Hubbard
NVIDIA