linux-kernel - Re: [PATCH] power: reset: nvmem-reboot-mode: add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6aa562a3-effe-12c2-25d8-47ecf583d724@vaisala.com>
Date:   Mon, 5 Aug 2019 10:10:14 +0300
From:   Nandor Han <nandor.han@...sala.com>
To:     Arnd Bergmann <arnd@...db.de>, Sebastian Reichel <sre@...nel.org>
Cc:     Sebastian Reichel <sebastian.reichel@...labora.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: reset: nvmem-reboot-mode: add CONFIG_OF dependency

On 7/8/19 3:52 PM, Arnd Bergmann wrote:
> Without CONFIG_OF, we get a build failure in the reboot-mode
> implementation:
> 
> drivers/power/reset/reboot-mode.c: In function 'reboot_mode_register':
> drivers/power/reset/reboot-mode.c:72:2: error: implicit declaration of function 'for_each_property_of_node'; did you mean 'for_each_child_of_node'? [-Werror=implicit-function-declaration]
>    for_each_property_of_node(np, prop) {
> 
> Add a Kconfig dependency like we have for the other users of
> CONFIG_REBOOT_MODE.
> 
> Fixes: 7a78a7f7695b ("power: reset: nvmem-reboot-mode: use NVMEM as reboot mode write interface")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/power/reset/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 8dfb105db391..a564237278ff 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -248,6 +248,7 @@ config POWER_RESET_SC27XX
>   
>   config NVMEM_REBOOT_MODE
>   	tristate "Generic NVMEM reboot mode driver"
> +	depends on OF
>   	select REBOOT_MODE
>   	help
>   	  Say y here will enable reboot mode driver. This will
> 

Wouldn't this be more appropriate to add the "depends on OF" to "config 
REBOOT_MODE" section, since this is an error to `reboot-mode.c` unit?

Nandor