linux-kernel - Re: KASAN: use-after-free Read in usb_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1564998287.4248.5.camel@suse.com>
Date:   Mon, 05 Aug 2019 11:44:47 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Suzuki K Poulose <suzuki.poulose@....com>, dtor@...omium.org,
        andreyknvl@...gle.com, syzkaller-bugs@...glegroups.com,
        robh@...nel.org, srinivas.kandagatla@...aro.org,
        gregkh@...uxfoundation.org, mans@...sr.com,
        mathias.payer@...elwelt.net, stern@...land.harvard.edu,
        syzbot+d1fedb1c1fdb07fca507@...kaller.appspotmail.com,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: KASAN: use-after-free Read in usb_free_coherent

Am Donnerstag, den 01.08.2019, 11:52 +0100 schrieb Suzuki K Poulose:
> 
> Looks like the yurex_delete() drops the ref count on the dev->udev
> way early in the function and then later tries to see if there
> are any other buffers associated with it worth releasing. So,
> I am guessing moving the usb_put_dev(), after we have finished
> all that might solve the issue ?

Hi,

the fix looks good to me.

	Regards
		Oliver