linux-kernel - [PATCH] MIPS: OCTEON: octeon-usb: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon,  5 Aug 2019 03:41:55 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Paul Burton <paul.burton@...s.com>, James Hogan <jhogan@...nel.org>
Cc:     Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>,
        "Gustavo A . R . Silva" <gustavo@...eddedor.com>
Subject: [PATCH] MIPS: OCTEON: octeon-usb: Mark expected switch fall-through

Since commit a035d552a93b ("Makefile: Globally enable fall-through
warning"), cavium_octeon_defconfig builds fail with

In file included from
arch/mips/cavium-octeon/octeon-usb.c:12:
arch/mips/cavium-octeon/octeon-usb.c: In function 'dwc3_octeon_clocks_start':
include/linux/device.h:1499:2: error: this statement may fall through
  _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/mips/cavium-octeon/octeon-usb.c:399:3: note:
			in expansion of macro 'dev_err'
  dev_err(dev, "Invalid ref_clk %u, using 100000000 instead\n",
  ^~~~~~~
arch/mips/cavium-octeon/octeon-usb.c:401:2: note: here
  case 100000000:
  ^~~~~~~

Mark the switch case to expect fall through.

Cc: Gustavo A. R. Silva <gustavo@...eddedor.com>
Signed-off-by: Guenter Roeck <linux@...ck-us.net>
---
 arch/mips/cavium-octeon/octeon-usb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/cavium-octeon/octeon-usb.c b/arch/mips/cavium-octeon/octeon-usb.c
index 1f730ded5224..8a16ab37aa11 100644
--- a/arch/mips/cavium-octeon/octeon-usb.c
+++ b/arch/mips/cavium-octeon/octeon-usb.c
@@ -398,6 +398,7 @@ static int dwc3_octeon_clocks_start(struct device *dev, u64 base)
 	default:
 		dev_err(dev, "Invalid ref_clk %u, using 100000000 instead\n",
 			clock_rate);
+		/* Fall through */
 	case 100000000:
 		mpll_mul = 0x19;
 		if (ref_clk_sel < 2)
-- 
2.7.4