linux-kernel - Re: [PATCH v2 20/34] xen: convert put_page() to put_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82afb221-52a2-b399-46f5-0ee1f21c3417@suse.com>
Date:   Mon, 5 Aug 2019 06:15:27 +0200
From:   Juergen Gross <jgross@...e.com>
To:     john.hubbard@...il.com, Andrew Morton <akpm@...ux-foundation.org>
Cc:     devel@...verdev.osuosl.org, Dave Chinner <david@...morbit.com>,
        Christoph Hellwig <hch@...radead.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Ira Weiny <ira.weiny@...el.com>, x86@...nel.org,
        linux-mm@...ck.org, Dave Hansen <dave.hansen@...ux.intel.com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        intel-gfx@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org, devel@...ts.orangefs.org,
        xen-devel@...ts.xenproject.org, John Hubbard <jhubbard@...dia.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        rds-devel@....oracle.com,
        Jérôme Glisse <jglisse@...hat.com>,
        Jan Kara <jack@...e.cz>, ceph-devel@...r.kernel.org,
        kvm@...r.kernel.org, linux-block@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-fbdev@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        linux-media@...r.kernel.org, linux-nfs@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-xfs@...r.kernel.org,
        netdev@...r.kernel.org, sparclinux@...r.kernel.org,
        Jason Gunthorpe <jgg@...pe.ca>
Subject: Re: [PATCH v2 20/34] xen: convert put_page() to put_user_page*()

On 05.08.19 00:49, john.hubbard@...il.com wrote:
> From: John Hubbard <jhubbard@...dia.com>
> 
> For pages that were retained via get_user_pages*(), release those pages
> via the new put_user_page*() routines, instead of via put_page() or
> release_pages().
> 
> This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
> ("mm: introduce put_user_page*(), placeholder versions").
> 
> This also handles pages[i] == NULL cases, thanks to an approach
> that is actually written by Juergen Gross.
> 
> Signed-off-by: Juergen Gross <jgross@...e.com>
> Signed-off-by: John Hubbard <jhubbard@...dia.com>
> 
> Cc: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> Cc: xen-devel@...ts.xenproject.org
> ---
> 
> Hi Juergen,
> 
> Say, this is *exactly* what you proposed in your gup.patch, so
> I've speculatively added your Signed-off-by above, but need your
> approval before that's final. Let me know please...

Yes, that's fine with me.


Juergen